Skip to content

Conversation

@Yashh56
Copy link
Contributor

@Yashh56 Yashh56 commented Sep 8, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #2546

Link to prove your SVG is correct and up-to-date.

@Yashh56
Copy link
Contributor Author

Yashh56 commented Sep 25, 2025

@canaleal @lunatic-fox @ReenigneArcher @ConX @weh Could I get a review please?

@Yashh56 Yashh56 requested a review from canaleal October 19, 2025 16:55
@ReenigneArcher
Copy link
Member

I don't really review icons, but I notice the PR title has extra whitespace. Should start with new icon: not new icon :

Once you change this, you will have to force push to the branch to get the workflow to pick up the change.

@Yashh56 Yashh56 changed the title new icon : cursor (original, original-wordmark) new icon: cursor (original, original-wordmark) Oct 22, 2025
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 30, 2025

Hey @canaleal, Can You Review these changes and help me with the original SVG file?

@Yashh56 Yashh56 changed the title new icon: cursor (original, original-wordmark) new icon: cursor (original, original-wordmark, plain) Nov 27, 2025
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added missing newlines. Everything else looks good to me

@weh weh added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Nov 27, 2025
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Yashh56
Copy link
Contributor Author

Yashh56 commented Dec 8, 2025

Hey @canaleal, Can You Review these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:check Trigger check-bot. Remove and re-add the label to re-trigger bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants