Skip to content

Conversation

@dantengsky
Copy link
Member

@dantengsky dantengsky commented Sep 10, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Vacuum2 ALL (call system$fuse_vacuum2()) should ignore SYSTEM dbs, not just processing DEFAULT dbs
    Otherwise some databases might be ignored incorrectly
  • Add some logs to vacuum2 ALL

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 10, 2025
@dantengsky dantengsky force-pushed the refactor-refine-vaccum2-all branch from 2fe72a0 to e8347bb Compare September 10, 2025 13:13
- Vacuum2 ALL should ignore SYSTEM dbs, not just processing DEFAULT dbs
- Add some logs to vacuum2 ALL
@dantengsky dantengsky force-pushed the refactor-refine-vaccum2-all branch from e8347bb to 610e32b Compare September 10, 2025 14:31
Handle table vacuum failures by continuing execution, as these are typically caused by transient object storage issues.
@dantengsky dantengsky marked this pull request as ready for review September 12, 2025 13:46
@dantengsky dantengsky merged commit 441c3ca into databendlabs:main Sep 12, 2025
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants