feat: enhance resource scheduling logs with clear status and configuration details #18684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
…ation details - Show specific configuration parameters (max_concurrency, max_running_queries) - Display current resource usage (X/Y slots used) - Include queue length and wait times for better visibility - Distinguish between workload group and warehouse limits with clear [BLOCKED]/[ACQUIRED] status
BohuTANG
force-pushed
the
improve-queue-scheduling-logs
branch
from
c69f550 to
6194d0a
Compare
zhang2014
approved these changes
Sep 4, 2025
- Replace subtraction with saturating_sub to avoid potential underflow - Simplify variable naming for better readability - Ensure thread-safe calculation of used slots
Contributor
Docker Image for PR
|
- Replace remaining generic status messages with specific blocked status - Update workload group global semaphore acquisition message - Ensure all code paths show detailed configuration information
- Add test to verify status messages during workload group concurrency limits - Simulate 100 concurrent queries with max_concurrency=16 - Capture and log status messages for debugging queue behavior
BohuTANG
added
ci-cloud
Contributor
Docker Image for PR
|
Member
Author
|
- Add queue length to workload group local limit messages - Add queue length to workload group global limit messages - Ensure consistency with warehouse limit messages that already show waiting count
- Replace [BLOCKED] with [WAITING] prefix for all queue status messages - More user-friendly indication that queries are waiting rather than blocked
BohuTANG
added
ci-cloud
Contributor
Docker Image for PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Replace generic "[QUERY-QUEUE] Waiting for resource scheduling" messages with specific, actionable logs that show:
max_concurrency=5,max_running_queries=85/5 slots used,3 queries waiting[BLOCKED]vs[ACQUIRED]with wait timesBefore:
After:
Users can now immediately identify bottlenecks and adjust the right configuration parameters.
Tests
Type of change
This change is