Skip to content

Conversation

@SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Aug 28, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR refactors runtime filter handling to use configurable settings instead of hardcoded constants, and replaces manual nested OR expression construction with the or_filters function for better performance and cleaner code.

  1. Replace Manual OR Expression Construction with or_filters

  2. Make Runtime Filter Thresholds Configurable. If the number of rows on the build side exceeds the limit at runtime, runtime filter construction will be stopped

Setting Default
inlist_runtime_filter_threshold 1,024
bloom_runtime_filter_threshold u64::MAX
min_max_runtime_filter_threshold u64::MAX

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 28, 2025
@sundy-li sundy-li merged commit a57986d into databendlabs:main Sep 1, 2025
166 of 168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants