fix: output lost after hotswapping #5346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the pipe was closing the other streams when the child stream closed so instead just write it one way.
jsjoeio
approved these changes
Jul 15, 2022
Contributor
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
This is one of those intricate pieces of the codebase where I'm really happy you know what's going wrong and how to fix 😂 Thanks for doing this!
Codecov Report
@@ Coverage Diff @@
## main #5346 +/- ##
==========================================
- Coverage 72.47% 72.38% -0.09%
==========================================
Files 30 30
Lines 1671 1673 +2
Branches 367 367
==========================================
Hits 1211 1211
- Misses 397 399 +2
Partials 63 63
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the pipe was closing the other streams when the child stream
closed so instead just write it one way.
This was making it quite difficult to debug code-server when doing live
edits in Coder.