-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: add missing package.json and source maps #5040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
7d9b15e
4107f11
ede7125
c24fa95
f228cc9
4ae5e26
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,11 +78,25 @@ EOF | |
| bundle_vscode() { | ||
| mkdir -p "$VSCODE_OUT_PATH" | ||
|
|
||
| # - Some extensions have a .gitignore which excludes their built source from | ||
| # the npm package so exclude any .gitignore files. | ||
| # - Exclude Node as we will add it ourselves for the standalone and will not | ||
| # need it for the npm package. | ||
| rsync -avh --exclude .gitignore --exclude /node ./lib/vscode-reh-web-*/ "$VSCODE_OUT_PATH" | ||
| local rsync_opts=() | ||
| if [[ ${DEBUG-} = 1 ]]; then | ||
| rsync_opts+=(-vh) | ||
| fi | ||
|
|
||
| # Some extensions have a .gitignore which excludes their built source from the | ||
| # npm package so exclude any .gitignore files. | ||
| rsync_opts+=(--exclude .gitignore) | ||
|
|
||
| # Exclude Node as we will add it ourselves for the standalone and will not | ||
| # need it for the npm package. | ||
| rsync_opts+=(--exclude /node) | ||
|
|
||
| # Exclude Node modules. | ||
| if [[ $KEEP_MODULES = 0 ]]; then | ||
| rsync_opts+=(--exclude node_modules) | ||
| fi | ||
|
|
||
| rsync "${rsync_opts[@]}" ./lib/vscode-reh-web-*/ "$VSCODE_OUT_PATH" | ||
|
Comment on lines
+84
to
+99
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This approach looks a lot cleaner 👏🏼 |
||
|
|
||
| # Add the commit, date, our name, links, and enable telemetry. This just makes | ||
| # telemetry available; telemetry can still be disabled by flag or setting. | ||
|
|
@@ -131,11 +145,6 @@ EOF | |
|
|
||
| rsync "$VSCODE_SRC_PATH/remote/yarn.lock" "$VSCODE_OUT_PATH/yarn.lock" | ||
|
|
||
| if [ "$KEEP_MODULES" = 0 ]; then | ||
| rm -Rf "$VSCODE_OUT_PATH/extensions/node_modules" | ||
| rm -Rf "$VSCODE_OUT_PATH/node_modules" | ||
| fi | ||
|
|
||
| pushd "$VSCODE_OUT_PATH" | ||
| symlink_asar | ||
| popd | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,14 +98,6 @@ vscode_yarn() { | |
|
|
||
| cd extensions | ||
| yarn --production --frozen-lockfile | ||
|
|
||
| for ext in */; do | ||
| ext="${ext%/}" | ||
| echo "extensions/$ext: installing dependencies" | ||
| cd "$ext" | ||
| yarn --production --frozen-lockfile | ||
| cd "$OLDPWD" | ||
| done | ||
|
Comment on lines
-101
to
-108
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. beautiful find
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hopefully I am not wrong about this removal hahaha
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Before the next release we might want to run through all the builtin extensions to see if we have any more issues with them
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea. I'll add a note to the release issue |
||
| } | ||
|
|
||
| main "$@" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
-vhstand for here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah:
-h: -h, --human-readable output numbers in a human-readable format-v: -v, --verbose increase verbositySource: https://linux.die.net/man/1/rsync