Add socket type to websocket connection query (regression) #3391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added a long time ago but accidentally lost when we reverted the retry changes to this file after one of the VS Code updates that added their own retry (we reverted everything not realizing we had other unrelated changes in here).
Codecov Report
@@ Coverage Diff @@
## main #3391 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 35 35
Lines 1709 1709
Branches 379 379
=======================================
Hits 1012 1012
Misses 559 559
Partials 138 138 Continue to review full report at Codecov.
|
jsjoeio
approved these changes
May 14, 2021
Contributor
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for adding that note too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added a long time ago but accidentally lost when we reverted
the retry changes to this file after one of the VS Code updates that
added their own retry (we reverted everything not realizing we had other
unrelated changes in here).
This is definitely one downside to the subtree over patches but I added
a note to help ensure we notice the change in case something similar
happens again.