feat: use compression in express server #2680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
reviewed
Feb 8, 2021
Contributor
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
Thanks for opening an issue and raising a PR @jpoehnelt 🎉
All looks good to me. Going to ask @code-asher to give a second-look who is more familiar with the Express app side of code-server.
code-asher
approved these changes
Feb 12, 2021
Member
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
Those are some great savings. Thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the compression middleware with default settings. Fixes #2679. This greatly improves loading performance over my horrible internet!
With compression:
Without compression: