Skip to content

vscode: Make eslint pass #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhooyr merged 3 commits into from
Nov 30, 2020
Merged

vscode: Make eslint pass #2374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5247878
ci: Enable vscode linting
nhooyr Nov 25, 2020
833314a
vscode: Make eslint pass
nhooyr Nov 27, 2020
4cb8a32
ci: Fetch vscode node_modules in lint.sh for eslint
nhooyr Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ci/dev/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ main() {
if command -v helm && helm kubeval --help > /dev/null; then
helm kubeval ci/helm-chart
fi

cd lib/vscode
# Run this periodically in vanilla VS code to make sure we don't add any more warnings.
yarn eslint --max-warnings=3
cd "$OLDPWD"
}

main "$@"
Loading