Skip to content

Fix extension install path for CLI #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhooyr merged 1 commit into from
May 27, 2020
Merged

Fix extension install path for CLI #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/node/entry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ const main = async (cliArgs: Args): Promise<void> => {
}
}

args = await setDefaults(args)

logger.info(`Using user-data-dir ${humanPath(args["user-data-dir"])}`)

logger.trace(`Using extensions-dir ${humanPath(args["extensions-dir"])}`)
Expand Down Expand Up @@ -129,9 +127,11 @@ const main = async (cliArgs: Args): Promise<void> => {
}

async function entry(): Promise<void> {
const tryParse = (): Args => {
const tryParse = async (): Promise<Args> => {
try {
return parse(process.argv.slice(2))
let args = parse(process.argv.slice(2))
args = await setDefaults(args)
return args
} catch (error) {
console.error(error.message)
process.exit(1)
Expand Down