Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/new-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ it accordingly for future releases.
- [ ] (*for specification changes only*) the `tags.cncf.io/container-device-interface/specs-go` version in `schema/go.mod`.
- [ ] Run `make mod-tidy` to update versions in `cmd/**/go.mod`.
- [ ] Run `make mod-verify` to ensure modules are up to date.
- [ ] (*for specification changes only*) Add a description to the specification changes in `SPEC.md`.
- [ ] (*for specification changes only*) Add a description to the specification changes and update the version in `SPEC.md`.
- [ ] (*for specification changes only*) Implement a `requiresV*` function for the target version in `specs-go/versions.go`.
- [ ] Merge the PR on sufficient approval.
- [ ] Create a `vX.Y.Z` tag.
Expand Down
2 changes: 1 addition & 1 deletion SPEC.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

## Version

This is CDI **spec** version **1.0.0**.
This is CDI **spec** version **1.1.0**.

### Update policy

Expand Down
4 changes: 2 additions & 2 deletions cmd/cdi/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ require (
github.com/spf13/cobra v1.6.0
gopkg.in/yaml.v3 v3.0.1
sigs.k8s.io/yaml v1.4.0
tags.cncf.io/container-device-interface v1.0.1
tags.cncf.io/container-device-interface v1.1.0
tags.cncf.io/container-device-interface/schema v0.0.0
tags.cncf.io/container-device-interface/specs-go v1.0.0
tags.cncf.io/container-device-interface/specs-go v1.1.0
)

require (
Expand Down
4 changes: 2 additions & 2 deletions cmd/validate/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ require (
github.com/xeipuuv/gojsonschema v1.2.0 // indirect
golang.org/x/mod v0.19.0 // indirect
sigs.k8s.io/yaml v1.4.0 // indirect
tags.cncf.io/container-device-interface v1.0.1 // indirect
tags.cncf.io/container-device-interface/specs-go v1.0.0 // indirect
tags.cncf.io/container-device-interface v1.1.0 // indirect
tags.cncf.io/container-device-interface/specs-go v1.1.0 // indirect
)

replace (
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
golang.org/x/sys v0.19.0
gopkg.in/yaml.v3 v3.0.1
sigs.k8s.io/yaml v1.4.0
tags.cncf.io/container-device-interface/specs-go v1.0.0
tags.cncf.io/container-device-interface/specs-go v1.1.0
)

require (
Expand Down
4 changes: 2 additions & 2 deletions schema/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ require (
github.com/stretchr/testify v1.7.0
github.com/xeipuuv/gojsonschema v1.2.0
sigs.k8s.io/yaml v1.4.0
tags.cncf.io/container-device-interface v1.0.1
tags.cncf.io/container-device-interface/specs-go v1.0.0
tags.cncf.io/container-device-interface v1.1.0
tags.cncf.io/container-device-interface/specs-go v1.1.0
)

require (
Expand Down
4 changes: 2 additions & 2 deletions specs-go/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func requiresV110(spec *Spec) bool {
}
}

if len(spec.ContainerEdits.NetDevices) != 0 {
if len(spec.ContainerEdits.NetDevices) > 0 {
return true
}

Expand All @@ -161,7 +161,7 @@ func requiresV110(spec *Spec) bool {
}
}

if len(dev.ContainerEdits.NetDevices) != 0 {
if len(dev.ContainerEdits.NetDevices) > 0 {
return true
}
}
Expand Down