api: Add all in-flight requests /reverse_proxy/upstreams (#7277) #7281
+79
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u5surf
commented
Sep 30, 2025
huang041
reviewed
Oct 22, 2025
Comment on lines
+844
to
+848
| di.Upstream.Host.countRequest(-1) | ||
| inflightHost := inflightHosts.Load(di.Address) | ||
| if inflightHost != nil { | ||
| host, _ := inflightHost.(*Host) | ||
| host.countRequest(-1) |
There was a problem hiding this comment.
di.Upstream.Host and inflightHost.(*Host) could point to the same Host, so countRequest(-1) might be applied twice.
huang041
reviewed
Oct 25, 2025
Comment on lines
+136
to
+142
| host := new(Host) | ||
| existingHost, loaded := inflightHosts.LoadOrStore(u.String(), host) | ||
| if loaded { | ||
| host = existingHost.(*Host) | ||
| } | ||
| _ = host.countRequest(numRemaiRequests) | ||
| u.Host = host |
There was a problem hiding this comment.
Just a thought - would it be simpler to just add the old host to inflightHosts rather than creating a new one?
Member
|
Wondering if a UsagePool is really the right abstraction for this. UsagePools are useful specifically for managing an allocated value based on reference counting. If the goal is to just count active requests per upstream, maybe a map of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assistance Disclosure
No AI was used.
Fixes: #7277
Introducing new usagePool named
inflightHostswhich store the host is still in-flight upstream in reverse proxy Cleanup phase. and when proxyLoopIteration returns done, the inflightHost drain in the usagePool.Here is scope for improvement because it is draft status now.