Jjbain bring your own arn #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment-system into jjbain-bring-your-own-arn
archieco
requested changes
Mar 2, 2023
Contributor
archieco
left a comment
archieco
left a comment
There was a problem hiding this comment.
@jjbainAWS nice work here! I just a few questions and a couple small requests.
| delete_stack(item['pipelineId']) | ||
| else: #Lambda Pipeline | ||
| delete_lambda(item['pipelineId']) | ||
| if item['userProvidedResource'] == "Not Provided": |
Contributor
There was a problem hiding this comment.
Under what circumstances would userProvidedResource be "Not Provided" but it's not something we want to delete? Can you think of any scenarios where this would accidentally delete customer applications?
| ) | ||
|
|
||
| #If a lambda function name or ECR container URI was provided by the user, creation is not necessary | ||
| if userResource != "Not Provided": |
Contributor
There was a problem hiding this comment.
Can we use a constant for "Not Provided" so that it's easier to keep track of references in the future?
…an object instead of a string, also added a check for pipeline deletion and workflow creation for pipelines that do not have a userProvidedResource attribute in their dynamodb entry
…e instead of the string. Also using null instead of null json.loads converts this to a None type in Python.
archieco
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK: As a VAMS customer I would like to define a pipeline to use a lambda function or ECR container image that is already in my account. I want to avoid deploying templates just to copy and paste my code anyways.
An additional optional field as been created in the create pipeline form and if an ECR image URI or lambda function name is provided, the API sends it over to createPipeline.py which updates the dynamo database with a new userProvidedResource attribute.
If this userProvidedResource is provided, then deployment of the SageMaker CFN template or lambda function is skipped.
In WorkflowPipelineSelector.js, the selector is configured to send the userProvidedResource field from the dynamo table item to the createWorkflow.py lambda function.
In createWorkflow.py if the userProvidedID is present, it is used to configure the steps in the state machine accordingly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.