Skip to content

Conversation

@arnewouters
Copy link
Contributor

@arnewouters arnewouters commented Dec 3, 2025

Fixes

Summary

Changes

Please provide a summary of what's being changed

Add botocore[crt] dependency to support credentials from aws login (#1824)

User experience

Please share what the user experience looks like before and after this change

This runtime error will no longer show up:

RuntimeError: Client failed to connect: Missing Dependency: Using the login credential provider requires an additional dependency. You will need to pip install "botocore[crt]" before proceeding.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@arnewouters arnewouters marked this pull request as ready for review December 3, 2025 06:41
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (20e7472) to head (06bc937).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
- Coverage   90.42%   90.40%   -0.03%     
==========================================
  Files         851      705     -146     
  Lines       63317    55657    -7660     
  Branches    10253     9199    -1054     
==========================================
- Hits        57254    50316    -6938     
+ Misses       3772     3288     -484     
+ Partials     2291     2053     -238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arnewouters arnewouters added this pull request to the merge queue Dec 8, 2025
Merged via the queue into awslabs:main with commit 9297a7d Dec 8, 2025
182 checks passed
@arnewouters arnewouters deleted the fix/support-aws-login branch December 8, 2025 06:22
@github-project-automation github-project-automation bot moved this from To triage to Done in awslabs/mcp Project Dec 8, 2025
JonLim pushed a commit to JonLim/mcp that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants