generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 15
test: fix failing integration tests #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ea7fd3 to
a73f3af
Compare
b3ddddd to
bad6e9f
Compare
bad6e9f to
7b405cb
Compare
karenc-bq
commented
Nov 28, 2025
| push: | ||
| branches: | ||
| - main | ||
| - test/hanging-efm2-integration-test |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove this once integration tests pass
10647db to
ff4f6a1
Compare
sophia-bq
reviewed
Nov 29, 2025
1b61e4f to
dc5e9f2
Compare
sophia-bq
approved these changes
Dec 1, 2025
faviansamatha
approved these changes
Dec 1, 2025
karenc-bq
commented
Dec 1, 2025
| assert idle_connection.is_closed is True | ||
|
|
||
| @enable_on_features([TestEnvironmentFeatures.NETWORK_OUTAGES_ENABLED]) | ||
| def test_failover__socket_timeout( |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleting this test case because it is already being covered by other tests
4816e8d to
865b506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hanging Tests
conn.close()may hang indefinitely. This PR wraps these direct calls in a timeout to ensure application doesn't block the main workflow when we only want to do a best attempt at closing a connection.Failing Tests
Chores
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.