fix(typescript-library): Organize types and add missing slash #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyvassallo
commented
Jul 11, 2024
| const fileIndex = parseInt(index, 10) - 1; | ||
| const fileName = dataNames[fileIndex]; | ||
| return fileName ? fileName.split(isWindows ? '\\' : '/').join('') : match; | ||
| return fileName ? (isWindows ? fileName.split('\\').join('/') : fileName) : match; |
Contributor
Author
There was a problem hiding this comment.
This is the only real change. The rest is just style
joshfried-aws
approved these changes
Jul 15, 2024
reza-aws
approved these changes
Jul 15, 2024
dannyvassallo
added a commit
to dannyvassallo/cloudformation-guard
that referenced
this pull request
Jul 15, 2024
joshfried-aws
pushed a commit
to joshfried-aws/cloudformation-guard
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Missed replacing with a slash and fixed messy logic
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license