-
-
Notifications
You must be signed in to change notification settings - Fork 301
feature: close_modal #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: close_modal #2345
Conversation
|
Code Climate has analyzed commit 1601215 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| when :close_modal | ||
| # Close the modal and flash the messages | ||
| render turbo_stream: [ | ||
| turbo_stream.remove("actions_show"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's create a custom stream action here close_action_modal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's create a custom stream action here close_action_modal.
Then it's good to be merged!
|
This PR has been merged into Please check the release guide for more information. |
Description
Fixes #2336
Adds the
close_modalaction's response option that flashes the alerts and closes the modal.Checklist:
Screenshots
close_modal.webm
Manual review steps
close_modalto an action