-
Notifications
You must be signed in to change notification settings - Fork 0
UPSTREAM PR #17824: cli: new CLI experience #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
loci-dev
wants to merge
24
commits into
main
Choose a base branch
from
upstream-PR17824-branch_ngxson-xsn/cli_server_based
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UPSTREAM PR #17824: cli: new CLI experience #479
loci-dev
wants to merge
24
commits into
main
from
upstream-PR17824-branch_ngxson-xsn/cli_server_based
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebc7ac8 to
5b191e7
Compare
074b005 to
ff6ae69
Compare
3595a58 to
51e8448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17824
Ref: ggml-org/llama.cpp#17618
Fix: #11202
We are moving to a new CLI experience with the main code built on top of
llama-server. This brings many additional features intollama-cli, making the experience feels mostly like a smaller version of the web UI:llama-clidoesn't support)TODO:
reasoning_contentwhen possible, depends on server: delegate result_state creation to server_task ggml-org/llama.cpp#17835console::readlineggml-org/llama.cpp#17828console::readlineggml-org/llama.cpp#17829Show progress if prompt processing takes too longquite complicated, do it later--imageand--audioargumentsllama-completionfor legacy features