[flake8-pyi] Fix PYI034 to not trigger on metaclasses (PYI034)
#20881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
AlexWaygood
requested changes
Oct 15, 2025
crates/ruff_linter/resources/test/fixtures/flake8_pyi/PYI034.pyi
Outdated
Show resolved
Hide resolved
Adds logic to identify classes with a metaclass-like __new__ method signature based on parameter count and type annotations. Updates is_metaclass to consider such signatures, improving detection of metaclasses that do not inherit from known metaclass bases.
AlexWaygood
approved these changes
Oct 24, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, I pushed a few edits. The implementation LGTM now.
@ntBre, I think you mentioned on the issue that it might be good to document this heuristic? That does seem like it might be worthwhile. I'll punt this back to you now, if that's okay 😄
ntBre
added
bug
Contributor
|
Thanks @AlexWaygood, this looks great! And you did all the hard work, I basically just copied your docstring into the rule docs 😄 |
AlexWaygood
reviewed
Oct 24, 2025
crates/ruff_linter/src/rules/flake8_pyi/rules/non_self_return_type.rs
Outdated
Show resolved
Hide resolved
Member
Ah I have to share credit with @danparizher for that docstring, he wrote half of it!! |
…type.rs Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20781