Skip to content

Conversation

@Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Sep 2, 2025

Summary

update the argument datasets as assets

Test Plan

update fixture accordingly

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+3 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

apache/airflow (+3 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ providers/openlineage/tests/system/openlineage/example_openlineage_schedule_asset_or_time_dag.py:53:9: AIR311 [*] `datasets` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
+ providers/openlineage/tests/unit/openlineage/plugins/test_utils.py:683:13: AIR311 [*] `datasets` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.
+ providers/openlineage/tests/unit/openlineage/utils/test_utils.py:1242:17: AIR311 [*] `datasets` is removed in Airflow 3.0; It still works in Airflow 3.0 but is expected to be removed in a future version.

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
AIR311 3 3 0 0 0

@ntBre ntBre added rule Implementing or modifying a lint rule preview Related to preview mode features labels Sep 3, 2025
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ntBre ntBre changed the title [airflow] add rule DatasetOrTimeSchedule(datasets=...) to AssetOrTimeSchedule(assets=...) (AIR311) [airflow] Convert DatasetOrTimeSchedule(datasets=...) to AssetOrTimeSchedule(assets=...) (AIR311) Sep 3, 2025
@ntBre ntBre merged commit 5d7c17c into astral-sh:main Sep 3, 2025
37 checks passed
second-ed pushed a commit to second-ed/ruff that referenced this pull request Sep 9, 2025
…TimeSchedule(assets=...)` (`AIR311`) (astral-sh#20202)

<!--
Thank you for contributing to Ruff/ty! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title? (Please prefix
with `[ty]` for ty pull
  requests.)
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->

update the argument `datasets` as `assets`

## Test Plan

<!-- How was it tested? -->

update fixture accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants