-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[flake8-gettext] Resolve qualified names and built-in bindings (INT001, INT002, INT003)
#19045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flake8-gettext] Resolve qualified names and built-in bindings (INT001, INT002, INT003)
#19045
Conversation
|
6a267e8 to
911adc3
Compare
flake8_gettext]: Make INTxxx rules also trigger on aliased importsflake8_gettext]: Expand scope of INTxxx rules
flake8_gettext]: Expand scope of INTxxx rulesflake8_gettext] Expand scope of INTxxx rules
CodSpeed Performance ReportMerging #19045 will not alter performanceComparing Summary
Footnotes
|
911adc3 to
f6fdd46
Compare
f6fdd46 to
eec7743
Compare
ntBre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me! Just a couple of small nits and the merge conflicts, if you don't mind resolving those.
|
@robsdedude do you think you get a chance to resolve the merge conflicts or would you prefer us to resolve them? |
Co-authored-by: Brent Westbrook <[email protected]>
|
Ok, this should be good for another review now. Sorry for the long wait. Life got in the way ;) |
flake8_gettext] Expand scope of INTxxx rulesflake8-gettext] Resolve qualified names and built-in bindings (INT001, INT002, INT003)
ntBre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Summary
Make rules
INT001,INT002, andINT003alsogettextmodule. For examplebuiltinsbindingsFixes: #19028
Test Plan
Tests have been added to all three rules.