[flake8-import-conventions] Add import numpy.typing as npt to default flake8-import-conventions.aliases

[amin-not-found]

Summary

Adds import numpy.typing as npt to default in flake8-import-conventions.aliases
Resolves #17028

Test Plan

Manually ran local ruff on the altered fixture and also ran cargo test

[ntBre]

Thanks! This looks good except for one question about the conventional test case.

If you end up changing that, it might be nice to move the new tests to the bottom of the test file too. That will make it much easier to review the changes since it won't move any of the other snapshots!

@MichaReiser does this need to be in preview? I think it's a new default restriction on the allowed name for the numpy.typing import, but I guess we'll see if there are any ecosystem hits.

[ntBre]

Is this one supposed to be import numpy.typing as npt?

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[amin-not-found]

Is this one supposed to be import numpy.typing as npt?

Yes, that's right. I forgot to type typing there. It should be fixed now.

it might be nice to move the new tests to the bottom of the test file too

I have changed it, but I was trying to keep the structure. Maybe I can reorder the imports by library instead, so that it has some kind of structure that is easy to keep whit new additions? Something like this:

import altair  # unconventional
import altair as altr  # unconventional
import altair as alt  # conventional

import dask.array  # unconventional
import dask.array as darray  # unconventional
...

Or maybe not if that's too much change.

[ntBre]

Nice! Yeah it's always a tradeoff on keeping the structure or not. I think it's okay like you have it now though, without worrying about rearranging the other cases.

Let's wait for confirmation on whether this needs to be preview-gated or not, but otherwise this looks good to me.

[amin-not-found]

Yeah I get it and also appreciate your feedback

[MichaReiser]

I think it's fine to ship this as is. I suspect that most numpy users added npt to their convention configuration already and, if not, it only removes the need for some suppression comments.