Ruff v0.7.3 not recognizing instance of SIM115 compared to v0.7.2

[CoolCat467]

In Ruff version 0.7.3, SIM115 is not recognized in a case that was recognized in 0.7.2:

file.py

from __future__ import annotations

import traceback
from typing import Any, IO


def open_file(
    filename: str,
    mode: str,
    encoding: str | None = None,
) -> IO[Any] | None:
    """Return file handle. Return None on failure."""
    try:
        # Line below previously correctly triggered `SIM115`
        return open(filename, mode, encoding=encoding)
    except FileNotFoundError:
        print("File Not Found.")
    except (OSError, BaseException) as exc:
        print(exc)
        traceback.print_exception(exc)
    return None

Noted line no longer triggers SIM115, where I argue it might be more correct to do so.

ruff check --isolated --select=SIM115 file.py

~ > ruff --version
ruff 0.7.3

[charliermarsh]

I believe this was an intentional change.

[zanieb]

Yes, per #14066 and #13862

The caller could context manage the returned object. It is incorrect to raise SIM115 here.

[CoolCat467]

Alright, that makes sense, thanks for clarifying!