Skip to content

Conversation

@brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Nov 17, 2025

This PR resolves []

cc @artsy/diamond-devs

Description

  • handle case when feature is null (don't show Unable to Load)
  • removes hairline above video sets
  • fixes issue in feature description causing bolded and italicized text not to match text styles
  • downsize text sizes and change colors to match force more closely

Follow-ups

  • having trouble with android setup, will do more testing there when I can
Platform Before After
Android
iOS
feature-before-low.mov
feature-after-low.mov

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • qa fixes for the feature page - brian

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@brainbicycle brainbicycle self-assigned this Nov 17, 2025
@brainbicycle brainbicycle marked this pull request as draft November 17, 2025 19:52
@brainbicycle brainbicycle marked this pull request as ready for review November 17, 2025 20:53
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (qa fixes for the feature page - brian - brainbicycle)

Generated by 🚫 dangerJS against 3c0ed0a

Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, thanks 🙏🏽

@brainbicycle brainbicycle merged commit e6f5f60 into main Nov 18, 2025
14 checks passed
@brainbicycle brainbicycle deleted the brian/feature-hairline branch November 18, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants