-
Notifications
You must be signed in to change notification settings - Fork 592
chore(EMI-2826): track complete profile button press #12796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems to be fine and should be working as expected, but when I saw the jira ticket, I noticed that the work is supposed to be tracking the events from the Order Details, am I missing something?
Edit: I just read the slack thread, nvm 😅
MrSltun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🌟
| const tracks = { | ||
| tappedCompleteYourProfile: (analytics: AnalyticsContextProps) => ({ | ||
| action: ActionType.tappedCompleteYourProfile, | ||
| context_module: ContextModule.collectorProfile, | ||
| context_screen_owner_type: OwnerType.profile, | ||
| context_screen_owner_id: analytics.contextScreenOwnerId, | ||
| }), | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion(non-blocking): Maybe we should add the return type TappedCompleteYourProfile from Cohesion here?
| const tracks = { | |
| tappedCompleteYourProfile: (analytics: AnalyticsContextProps) => ({ | |
| action: ActionType.tappedCompleteYourProfile, | |
| context_module: ContextModule.collectorProfile, | |
| context_screen_owner_type: OwnerType.profile, | |
| context_screen_owner_id: analytics.contextScreenOwnerId, | |
| }), | |
| } | |
| const tracks = { | |
| tappedCompleteYourProfile: (analytics: AnalyticsContextProps): TappedCompleteYourProfile => ({ | |
| action: ActionType.tappedCompleteYourProfile, | |
| context_module: ContextModule.collectorProfile, | |
| context_screen_owner_type: OwnerType.profile, | |
| context_screen_owner_id: analytics.contextScreenOwnerId, | |
| }), | |
| } |
This PR resolves EMI-2826
Description
This PR adds the tracking event
tappedCompleteYourProfileto the "Complete Profile" button on the user profile page.@artsy/emerald-devs
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.