Skip to content

Conversation

@rquartararo
Copy link
Member

@rquartararo rquartararo commented Sep 29, 2025

This PR resolves EMI-2826

Description

This PR adds the tracking event tappedCompleteYourProfile to the "Complete Profile" button on the user profile page.

@artsy/emerald-devs

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • track tappedCompleteYourProfile

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Sep 29, 2025

This PR contains the following changes:

  • Cross-platform user-facing changes (track tappedCompleteYourProfile - rquartararo)

Generated by 🚫 dangerJS against eae620d

@rquartararo rquartararo requested a review from oxaudo September 30, 2025 13:05
@rquartararo rquartararo requested review from MrSltun and removed request for oxaudo September 30, 2025 13:46
Copy link
Member

@MrSltun MrSltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems to be fine and should be working as expected, but when I saw the jira ticket, I noticed that the work is supposed to be tracking the events from the Order Details, am I missing something?

Edit: I just read the slack thread, nvm 😅

Copy link
Member

@MrSltun MrSltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🌟

Comment on lines +325 to +332
const tracks = {
tappedCompleteYourProfile: (analytics: AnalyticsContextProps) => ({
action: ActionType.tappedCompleteYourProfile,
context_module: ContextModule.collectorProfile,
context_screen_owner_type: OwnerType.profile,
context_screen_owner_id: analytics.contextScreenOwnerId,
}),
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion(non-blocking): Maybe we should add the return type TappedCompleteYourProfile from Cohesion here?

Suggested change
const tracks = {
tappedCompleteYourProfile: (analytics: AnalyticsContextProps) => ({
action: ActionType.tappedCompleteYourProfile,
context_module: ContextModule.collectorProfile,
context_screen_owner_type: OwnerType.profile,
context_screen_owner_id: analytics.contextScreenOwnerId,
}),
}
const tracks = {
tappedCompleteYourProfile: (analytics: AnalyticsContextProps): TappedCompleteYourProfile => ({
action: ActionType.tappedCompleteYourProfile,
context_module: ContextModule.collectorProfile,
context_screen_owner_type: OwnerType.profile,
context_screen_owner_id: analytics.contextScreenOwnerId,
}),
}

@rquartararo rquartararo merged commit bae0dd8 into main Sep 30, 2025
7 checks passed
@rquartararo rquartararo deleted the rquartararo/track-complete-profile-press branch September 30, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants