-
Notifications
You must be signed in to change notification settings - Fork 592
feat: add gh actions workflows for building and deploying android and ios to Firebase and TestFlight #12606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…base and TestFlight
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
aac4d77 to
c69681f
Compare
…oid and iOS deployments
…d remove beta deployment step
| run: ./scripts/setup/install-bin | ||
|
|
||
| - name: Install imagemagick & librsvg for badge | ||
| run: brew install imagemagick librsvg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for later: common steps for both iOS and android can probably be separated out into a file and reused in both jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments but looks great! thank you!
I think before and after photos might be switched
Co-authored-by: Brian Beckerle <[email protected]>
Co-authored-by: Brian Beckerle <[email protected]>
Co-authored-by: Brian Beckerle <[email protected]>
Co-authored-by: Brian Beckerle <[email protected]>
|
we can ignore the failing test - it was fixed in main |
MounirDhahri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work
This PR resolves PHIRE-1995
Description
removes:
and moves them to github actions.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.