Skip to content

Conversation

@gkartalis
Copy link
Member

@gkartalis gkartalis commented Aug 7, 2025

This PR resolves PHIRE-1995

Description

removes:

  • build-deploy-android-firebase
  • build-deploy-android-playstore
  • build-deploy-ios-firebase
  • build-deploy-ios-testflight

and moves them to github actions.

Before After
Screenshot 2025-08-19 at 18 13 25 Screenshot 2025-08-19 at 18 10 39
Screenshot 2025-08-19 at 18 13 37

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • move beta builds to gh actions

Need help with something? Have a look at our docs, or get in touch with us.

@gkartalis gkartalis self-assigned this Aug 7, 2025
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Aug 7, 2025

This PR contains the following changes:

  • Dev changes (move beta builds to gh actions - gkartalis)

Generated by 🚫 dangerJS against 388bf99

@gkartalis gkartalis force-pushed the gkartalis/PHIRE-1995 branch from aac4d77 to c69681f Compare August 19, 2025 08:36
@gkartalis gkartalis requested a review from brainbicycle August 19, 2025 16:14
run: ./scripts/setup/install-bin

- name: Install imagemagick & librsvg for badge
run: brew install imagemagick librsvg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for later: common steps for both iOS and android can probably be separated out into a file and reused in both jobs

brainbicycle
brainbicycle previously approved these changes Aug 19, 2025
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments but looks great! thank you!

I think before and after photos might be switched

@gkartalis
Copy link
Member Author

we can ignore the failing test - it was fixed in main

@gkartalis gkartalis merged commit b6bdf3b into main Aug 20, 2025
4 of 5 checks passed
@gkartalis gkartalis deleted the gkartalis/PHIRE-1995 branch August 20, 2025 14:32
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work

@gkartalis gkartalis changed the title feat: add gh actions workflows for building and deploying iOS to Firebase and TestFlight feat: add gh actions workflows for building and deploying android and ios to Firebase and TestFlight Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants