Skip to content

Conversation

@MrSltun
Copy link
Member

@MrSltun MrSltun commented Aug 1, 2025

This PR resolves PBRW-1073

Description

This PR fixes the crash that happens on Android when using the analytics visualizer

The issue comes from React Native removing BackHandler.removeEventListener in 0.77, but it was still being used by @expo/react-native-action-sheet, which is causing the app to crash on Android

The fix: Upgrading @expo/react-native-action-sheet to v4.1.1, which includes the removal of BackHandler.removeEventListener from the package

Before After
analytics-crash-before-low.mp4
analytics-crash-after-low.mp4

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

  • Fix app crash on analytics visualizer tap

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Android user-facing changes (Fix app crash on analytics visualizer tap - MrSltun)

Generated by 🚫 dangerJS against 0f8e3e6

Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! this probably should be included in the release then right?

@MrSltun
Copy link
Member Author

MrSltun commented Aug 4, 2025

Yeah I'll cherry pick it to the release candidate branch

@MrSltun MrSltun merged commit 71040a2 into main Aug 4, 2025
7 checks passed
@MrSltun MrSltun deleted the mrsltun/PBRW-1073/fix-analytics-crash-on-android branch August 4, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants