Skip to content

chore(MOPRAT-837): Migrate to Artsy Icons #12540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artsy-peril merged 72 commits into from
Jul 30, 2025
Merged

chore(MOPRAT-837): Migrate to Artsy Icons #12540

artsy-peril merged 72 commits into from
Jul 30, 2025

Conversation

@MrSltun
Copy link
Member

@MrSltun MrSltun commented Jul 25, 2025 •
edited
Loading

This PR resolves MOPRAT-837

Description

This PR migrates all icons from Palette Mobile to be imported from Artsy Icons

Screenshots

Screenshots
Icon Before After
ArtsyLogoWhiteIcon (⚠️ behind a feature flag ⚠️) image image
CloseIcon image image
ChevronIcon (direction: Right) image image
ChevronIcon (direction: Down) image image
ChevronIcon (direction: Left) image image
LogoutIcon image image
ReloadIcon image image
EditIcon image image
EyeOpenedIcon image image
ArrowLeftIcon image image
ArrowRightIcon image image
BellIcon image image
DecreaseIcon image image
IncreaseIcon image image
CheckIcon image image
FilterIcon image image
EyeClosedIcon image image
NoImageIcon image image
CheckCircleIcon image image
EmptyCheckCircleIcon image image
AddIcon image image
InfoCircleIcon image image
HeartFillIcon image image
HeartIcon image image
MagnifyingGlassIcon image image
XCircleIcon image image
StarCircleIcon (new screenshot) image image
NoArtworkIcon image image
TimerIcon image image
InstagramAppIcon (new screenshot) image image
MoreIcon image image
ShareIcon image image
WhatsAppAppIcon image image
ImageSetIcon N/A N/A
ArtsyLogoBlackIcon image image
VerifiedIcon image image
SecureLockIcon image image
CheckCircleFillIcon image image
CloseCircleFillIcon image image
CloseCircleIcon N/A N/A
EnvelopeIcon image image
CertificateIcon image image
ArtworkIcon image image
AuctionIcon image image
TrashIcon image image
TrendingIcon image image
InstitutionIcon image image
AddCircleIcon image image
FacebookIcon (⚠️ inaccessible via the app ⚠️ ) image image
TwitterIcon (⚠️ inaccessible via the app ⚠️ ) image image
SortIcon N/A N/A
MultiplePersonsIcon image image
QuestionCircleIcon image image
SettingsIcon image image
TagIcon image image
GraphIcon image image
ArrowDownIcon image image
ArrowUpIcon image image
MoneyFillIcon image image
AlertCircleFillIcon image image
DocumentIcon image image
DownloadIcon (⚠️ not used in app ⚠️) image image
StarCircleFill (new screenshot) image image
ExclamationMarkCircleFill image image
FairIcon image image
PublicationIcon image image
UserMultiIcon image image
UserSingleIcon image image
CreditCardIcon (⚠️ used in old order details screen ⚠️ ) image image

Follow-up

  • Remove Icons code in Palette Mobile (MOPRAT-863)
  • Update image icons to use Artsy Icons files (MOPRAT-864)

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Migrate to Artsy icons

Need help with something? Have a look at our docs, or get in touch with us.

@MrSltun MrSltun self-assigned this Jul 25, 2025
@MrSltun MrSltun marked this pull request as ready for review July 28, 2025 18:20
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jul 28, 2025 •
edited
Loading

This PR contains the following changes:

  • Dev changes (Migrate to Artsy icons - MrSltun)

Generated by 🚫 dangerJS against 3bff1d9

anandaroop
anandaroop previously approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is huge! 🤩

Looks great, just a couple of non-blocking minor Qs below…

@dariakoko
Copy link
Contributor

dariakoko commented Jul 29, 2025

When scrolling down the artist page the share icon on the top right moved further to the right. Wondering if it's been there before
image

dariakoko
dariakoko previously approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@dariakoko dariakoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sultan 👏 It really improves dev experience

@MrSltun
Copy link
Member Author

MrSltun commented Jul 29, 2025 •
edited
Loading

@dariakoko I see the share icon in the right position on my end 👀
image

Maybe there's something wrong with the animation?

gkartalis
gkartalis previously approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

araujobarret
araujobarret previously approved these changes Jul 29, 2025
View reviewed changes
brainbicycle
brainbicycle previously approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! and thank you for the screenshots! I think these ones that are against images are supposed to have a white outline:
471637658-1df0c90c-8e2e-4f13-a728-f9943822cff2-2
471631535-76cbc2d0-42f4-470a-bc78-cc025b46630f
Otherwise looks great!

@MrSltun
Copy link
Member Author

MrSltun commented Jul 29, 2025

471631535-76cbc2d0-42f4-470a-bc78-cc025b46630f

@brainbicycle Regarding the XCircleIcon, we already have one that's very similar to it called CloseFillIcon and it's used in a lot of places, would it be okay if we use the new one? 👀

471637658-1df0c90c-8e2e-4f13-a728-f9943822cff2-2

But regarding StarCircleFill, since we added it to Artsy Icons, I'll add the white border to it in artsy/icons#99 🫡

@brainbicycle
Copy link
Contributor

brainbicycle commented Jul 29, 2025

471631535-76cbc2d0-42f4-470a-bc78-cc025b46630f

@brainbicycle Regarding the XCircleIcon, we already have one that's very similar to it called CloseFillIcon and it's used in a lot of places, would it be okay if we use the new one? 👀

471637658-1df0c90c-8e2e-4f13-a728-f9943822cff2-2

But regarding StarCircleFill, since we added it to Artsy Icons, I'll add the white border to it in artsy/icons#99 🫡

that's fine! thanks!

@MrSltun
Copy link
Member Author

MrSltun commented Jul 30, 2025

@brainbicycle @anandaroop I updated the icons and the screenshots (marked with (new screenshot)) in the PR description

@MrSltun MrSltun force-pushed the mrsltun/MOPRAT-837/migrate-to-artsy-icons branch from ccc65aa to 5579963 Compare July 30, 2025 13:01
@MrSltun MrSltun force-pushed the mrsltun/MOPRAT-837/migrate-to-artsy-icons branch from 5579963 to 06898d4 Compare July 30, 2025 13:32
anandaroop
anandaroop previously approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@MrSltun MrSltun added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Jul 30, 2025
@artsy-peril artsy-peril bot merged commit 5e5980c into main Jul 30, 2025
7 checks passed
@artsy-peril artsy-peril bot deleted the mrsltun/MOPRAT-837/migrate-to-artsy-icons branch July 30, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandaroop anandaroop anandaroop left review comments

@araujobarret araujobarret araujobarret left review comments

@gkartalis gkartalis gkartalis left review comments

@dariakoko dariakoko dariakoko left review comments

@brainbicycle brainbicycle brainbicycle left review comments

@MounirDhahri MounirDhahri Awaiting requested review from MounirDhahri

Assignees

@MrSltun MrSltun

Labels

Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@MrSltun @ArtsyOpenSource @dariakoko @brainbicycle @anandaroop @araujobarret @gkartalis