Skip to content

Conversation

@downfa11
Copy link
Contributor

Fixes[#23521]


As discussed in the issue, I have only implemented sorting by sync-order.

I would also like to implement sorting for other columns, so I plan to open a follow-up issue to ask for opinions on this.

Problem

Currently, the List view doesn't provide a way to sort resources by their sync wave.(argocd.argoproj.io/sync-wave)

Impact

Now, Sorting the application list by the sync-order is also possible.

스크린샷 2025-08-18 231127 스크린샷 2025-08-18 231141

Changed

  • Modified the ApplicationResourceList component to introduce useState for managing sort configuration. (ui/src/app/applications/components/application-details/application-resource-list.tsx)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@downfa11 downfa11 requested a review from a team as a code owner August 18, 2025 15:14
@bunnyshell
Copy link

bunnyshell bot commented Aug 18, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault merged commit 762114c into argoproj:master Sep 11, 2025
24 checks passed
@downfa11 downfa11 deleted the feat/sort-by-sync-order branch September 12, 2025 09:17
@Aglowharmony Aglowharmony mentioned this pull request Sep 22, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants