-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat: add sso-host flag for OAuth2 login configuration (#22738) #22784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: PaleHazy <[email protected]>
|
I am not sure if I should change to actually bind to localhost instead hardcoded |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22784 +/- ##
==========================================
- Coverage 60.46% 60.42% -0.05%
==========================================
Files 350 350
Lines 60105 60113 +8
==========================================
- Hits 36345 36325 -20
- Misses 20828 20849 +21
- Partials 2932 2939 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: PaleHazy <[email protected]>
Signed-off-by: PaleHazy <[email protected]>
agaudreault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You need to run make codegen-local to generate the docs
Signed-off-by: Alexandre Gaudreault <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: PaleHazy <[email protected]>
Closes #22738
I updated the login and relogin command to have the ability to overwrite the callback scheme, host and port as one flag for the local server
this is necessary for some environments that are not the local machine and need to be redirected elsewhere from the idp.
I did not see any unit tests that were testing changing the port so I figured this would be fine. I can add some if there is a want for the callback validation
Checklist: