-
Notifications
You must be signed in to change notification settings - Fork 125
Add Unavailable result status #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This was referenced Sep 3, 2025
This was referenced Sep 26, 2025
This was referenced Oct 3, 2025
This was referenced Oct 10, 2025
This was referenced Nov 2, 2025
This was referenced Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making calls to downstream services or databases transient errors could occur that may get resolved if the operation is retried.
This PR adds an Unavailable result status and a mapping to a 503 Service Unavailable http result.
Usage scenarios:
A service adds a resiliency layer (using Polly for example) to handle retries.
instead of handling various exception or error types in the shared resiliency layer, the developer can handle these cases closer to where they occur and return Result.Unavailable. the resiliency layer can now be made generic, and error agnostic, and retry based on the result status.
while making a call to a downstream service, we get some transient error (database unavailable). the service layer can handle the error and return Result.Unavailable and the result will be converted to a 503 http response instead of a default 500 or 422.
Callers of our API get a better experience and can add their own resiliency layers if needed.