perf(helm): load in-memory files #6383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of copying files to a temporary folder, we can pass virutal files to helm, which improves performance.
benchstat old.txt new.txt goos: darwin goarch: arm64 pkg: github.com/aquasecurity/trivy/pkg/iac/scanners/helm/test │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ _RenderChartFiles-8 2138.1µ ± 2% 978.3µ ± 3% -54.24% (p=0.000 n=10) │ old.txt │ new.txt │ │ B/op │ B/op vs base │ _RenderChartFiles-8 570.4Ki ± 0% 532.8Ki ± 0% -6.59% (p=0.000 n=10) │ old.txt │ new.txt │ │ allocs/op │ allocs/op vs base │ _RenderChartFiles-8 7.714k ± 0% 7.476k ± 0% -3.09% (p=0.000 n=10)Checklist