refactor: use Trivy's public Go API instead of internal packages #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace mapfs.New() with fstest.MapFS in createDataFS() - Replace CycloneDXWriter with k8s.Write in cluster controller - Update compliance imports to use public types package - Update go.mod to use Trivy fork with public API changes TODO: Update go.mod to use main branch after aquasecurity/trivy#9606 merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the codebase to use Trivy's public Go API instead of packages that will be moved to internal.
Changes include:
mapfs.New()withfstest.MapFSincreateDataFS()CycloneDXWriterwithk8s.Writein cluster controllerDependencies
This PR depends on aquasecurity/trivy#9606 which moves some packages to internal.
Currently using Trivy fork commit
869a6b0895def51a9ea4b0b6d92ebc1724a7df47via go.mod replace directive.Once PR #9606 is merged, the replace directive should be updated to use the main branch or tagged version.