feat: Add `inherit` timeout option for `Actor.call` and `Actor.start` #518

Pijukatel · 2025-11-28T13:34:25Z

Add RemainingTime timeout option for Actor.call, Actor.start and Actor.callTask. This will set the timeout of another Actor run to whatever is left from the timeout of the current Actor run

Related to: apify/apify-client-js#632
Python implementation: apify/apify-sdk-python#473

barjin

This looks pretty straightforward implementation-wise, so it's almost a go from me 👍

I have these two points to discuss:

packages/apify/src/actor.ts

barjin · 2025-11-28T14:15:29Z

packages/apify/src/actor.ts

+     * Using `RemainingTime` will set timeout of the other Actor run to the time
+     * remaining from this Actor run timeout.
+     */
+    timeout?: number | 'RemainingTime';


The Pascal-cased string constant doesn't feel right, format-wise. How about 'inherit'?

Not sure about the common casing of string literals in JS, but this is the same literal as in the Python implementation. So, unless there is some name suggestion that is better by a lot, then I would prefer to keep it consistent.

I also like inherit much better.

So what do we do with the Python version now? Deprecate RemainingTime in favor of inherit?

I'd be up for that, what do you think about the naming here?

Yeah, I don't mind it 🙂

apify/apify-sdk-python#697

Co-authored-by: Jindřich Bär <[email protected]>

packages/apify/src/actor.ts

janbuchar · 2025-12-02T10:01:49Z

packages/apify/src/actor.ts

+     */
+    private _getRemainingTime(): number | undefined {
+        const env = this.getEnv();
+        if (env.isAtHome === '1' && env.timeoutAt !== null) {


Suggested change

if (env.isAtHome === '1' && env.timeoutAt !== null) {

if (Boolean(env.isAtHome) && env.timeoutAt !== null) {

should be just this.isAtHome()

Oh, we're in Actor 🤦 you're right

Using this.isAtHome()

janbuchar · 2025-12-02T10:04:13Z

packages/apify/src/actor.ts

+            return env.timeoutAt.getTime() - Date.now();
+        }
+        log.warning(
+            'Returning `undefined` instead of remaining time. Using `inherit` argument is only possible when ' +


The user reading this message won't understand what "Returning undefined" means. I think we could just remove the first sentence and keep the second one.

Ok, removed.

Co-authored-by: Jan Buchar <[email protected]>

B4nan

the changes in the lockfile feels a bit suspicious, surely unrelated

barjin

lgtm, thank you!

Two nits:

please update the PR title (inherit instead of RemainingTime)
When do we add this option for ActorTask.call / start? Should this happen in this PR?

…timeout-option

Pijukatel added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 28, 2025

github-actions bot assigned Pijukatel Nov 28, 2025

github-actions bot added this to the 128th sprint - Tooling team milestone Nov 28, 2025

github-actions bot added the tested Temporary label used only programatically for some analytics. label Nov 28, 2025

Pijukatel changed the title ~~feat: Add 'RemainingTime' timeout option for Actor.call and Actor.start~~ feat: Add RemainingTime timeout option for Actor.call and Actor.start Nov 28, 2025

Pijukatel force-pushed the add-remaining-time-timeout-option branch from 08efc4b to 3fc6e13 Compare November 28, 2025 13:53

Add RemainingTime timeout option for Actor.call and Actor.start

8cbd80d

Pijukatel force-pushed the add-remaining-time-timeout-option branch from 3fc6e13 to 8cbd80d Compare November 28, 2025 13:54

Pijukatel requested review from barjin and janbuchar November 28, 2025 13:56

Pijukatel marked this pull request as ready for review November 28, 2025 13:56

barjin reviewed Nov 28, 2025

View reviewed changes

Pijukatel requested a review from barjin December 1, 2025 08:19

Pijukatel force-pushed the add-remaining-time-timeout-option branch 2 times, most recently from 4adfd51 to f8962e6 Compare December 1, 2025 08:35

Update packages/apify/src/actor.ts

358ad03

Co-authored-by: Jindřich Bär <[email protected]>

Pijukatel force-pushed the add-remaining-time-timeout-option branch from f8962e6 to 358ad03 Compare December 1, 2025 08:36

Change RemainingTime to inherit

f8f383f

Pijukatel force-pushed the add-remaining-time-timeout-option branch from 1d8b73b to f8f383f Compare December 1, 2025 09:35

janbuchar reviewed Dec 2, 2025

View reviewed changes

packages/apify/src/actor.ts Outdated Show resolved Hide resolved

janbuchar reviewed Dec 2, 2025

View reviewed changes

Pijukatel mentioned this pull request Dec 3, 2025

Change RemainingTime literal to inherit apify/apify-sdk-python#697

Open

Pijukatel and others added 2 commits December 3, 2025 09:21

Update packages/apify/src/actor.ts

0a0f4a5

Co-authored-by: Jan Buchar <[email protected]>

Review comments

b7106f2

Pijukatel requested review from B4nan and janbuchar December 3, 2025 08:32

B4nan approved these changes Dec 3, 2025

View reviewed changes

barjin approved these changes Dec 3, 2025

View reviewed changes

Pijukatel changed the title ~~feat: Add RemainingTime timeout option for Actor.call and Actor.start~~ feat: Add inherit timeout option for Actor.call and Actor.start Dec 3, 2025

Add to inherit timeout option to Actor.callTask

a9b4507

Pijukatel force-pushed the add-remaining-time-timeout-option branch from 39db1a1 to a9b4507 Compare December 3, 2025 12:01

Pijukatel added 2 commits December 3, 2025 13:02

Merge remote-tracking branch 'origin/master' into add-remaining-time-…

5b68ba3

…timeout-option

Revert unintentional lock file edits

c3b53bc

janbuchar approved these changes Dec 3, 2025

View reviewed changes

Pijukatel merged commit 4bf3c0e into master Dec 4, 2025
10 checks passed

Pijukatel mentioned this pull request Dec 8, 2025

chore: Use inherit instead of RemainingTime apify/apify-sdk-python#701

Open

	if (env.isAtHome === '1' && env.timeoutAt !== null) {
	if (Boolean(env.isAtHome) && env.timeoutAt !== null) {

feat: Add inherit timeout option for Actor.call and Actor.start #518

feat: Add inherit timeout option for Actor.call and Actor.start #518

Uh oh!

Conversation

Pijukatel commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barjin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janbuchar Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

B4nan left a comment

Choose a reason for hiding this comment

Uh oh!

barjin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: Add `inherit` timeout option for `Actor.call` and `Actor.start` #518

feat: Add `inherit` timeout option for `Actor.call` and `Actor.start` #518

Pijukatel commented Nov 28, 2025 •

edited

Loading

janbuchar Dec 2, 2025 •

edited

Loading