Skip to content

Conversation

@loupipalien
Copy link
Contributor

Purpose of this pull request

Fix embedding output columns vector dimension that causes milvus create collection error, close #9645

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case?

@loupipalien
Copy link
Contributor Author

test case?

ok

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @loupipalien

@loupipalien loupipalien changed the title [Bug] [Transform-V2] Fix embedding output columns vector dimension [Fix] [Transform-V2] Fix embedding output columns vector dimension Jul 31, 2025
@loupipalien
Copy link
Contributor Author

loupipalien commented Aug 1, 2025

LGTM if ci passes. Thanks @loupipalien

@Hisoka-X The ci of some modules still fails after retrying, but it doesn't seem to be caused by the changes in the PR. How can i solve this problem, do you have any suggestions?
image

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 1, 2025

Try rebese on dev then trigger it again.

@loupipalien loupipalien force-pushed the fix-embedding-column-vector-dimension branch from 485dcda to d02059d Compare August 1, 2025 04:09
@corgy-w corgy-w merged commit f784059 into apache:dev Aug 4, 2025
4 checks passed
@loupipalien loupipalien deleted the fix-embedding-column-vector-dimension branch August 4, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Transform-V2] Milvus create collection error because of vector field dimension is null

3 participants