-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Fix][Transform-V2] Reduce embedding precision from double to float #9635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think we can start by reducing the embedding precision from double to float. The precision loss isn’t just happening with Zhipu—it’s actually an issue with almost all models where the embedding type is returned as double, like
So, as a quick fix, we can switch to float for now and add a note in the docs to let users know. @Hisoka-X |
+1. Next step, we should support double vector type. |
|
Thanks @xiaochen-zhou . Could you add a test case to cover it? |
OK. |
@Hisoka-X @xiaochen-zhou Another question, is there a plan to support multimodal embeddings?https://www.volcengine.com/docs/82379/1523520 |
I think this suggestion is great, and I would be happy to try implementing it. @Hisoka-X |
+1 |
Hisoka-X
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiaochen-zhou


Purpose of this pull request
Reduce embedding precision from double to float,close #9611
Does this PR introduce any user-facing change?
no
How was this patch tested?
Exists tests
Check list
New License Guide