Skip to content

[Fix][Connector-V2] Fix oceanbase mysql jdbc sink create statement error #9267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidzollo merged 3 commits into from
May 10, 2025
Merged

[Fix][Connector-V2] Fix oceanbase mysql jdbc sink create statement error #9267

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caca04f
[Fix] Fix oceanbase mysql jdbc sink create statement error
Hisoka-X May 6, 2025
cbc2b8d
Merge branch 'refs/heads/dev' into fix-ob-mysql-param
Hisoka-X May 8, 2025
43a0d5b
Merge branch 'refs/heads/dev' into fix-ob-mysql-param
Hisoka-X May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...seatunnel/connectors/seatunnel/jdbc/internal/dialect/oceanbase/OceanBaseMysqlDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ public String extractTableName(TablePath tablePath) {
public Map<String, String> defaultParameter() {
HashMap<String, String> map = new HashMap<>();
map.put("rewriteBatchedStatements", "true");
Copy link

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a comment explaining why the "allowMultiQueries" parameter is necessary for clarity and future maintainability.

Suggested change
map.put("rewriteBatchedStatements", "true");
map.put("rewriteBatchedStatements", "true");
// Enable multiple SQL queries in a single statement. This is required for certain
// OceanBase MySQL operations that rely on executing multiple queries together.
// Note: Use with caution as it may increase the risk of SQL injection if inputs are not sanitized.

Copilot uses AI. Check for mistakes.
map.put("allowMultiQueries", "true");
return map;
}

Expand Down