[Fix][Connector-V2] Fix load state check in MilvusSourceReader to consider partition-level status #8937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sider partition-level status
xiaochen-zhou
changed the title
xiaochen-zhou
changed the title
Hisoka-X
reviewed
Mar 10, 2025
Comment on lines
+170
to
+172
| if (StringUtils.isNotEmpty(partitionName)) { | ||
| loadStateParam.withPartitionNames(Collections.singletonList(partitionName)); | ||
| } |
Member
There was a problem hiding this comment.
Thanks @xiaochen-zhou . Could you add a test case for this?
Contributor
Author
There was a problem hiding this comment.
Thanks @xiaochen-zhou . Could you add a test case for this?
OK.
Member
|
waiting test case passes. |
Contributor
Author
Done. |
Hisoka-X
approved these changes
Mar 19, 2025
hailin0
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Fix load state check in MilvusSourceReader to consider partition-level status
Does this PR introduce any user-facing change?
no
How was this patch tested?
exists tests
Check list
New License Guide
release-note.