[Feature][Jdbc] Support sink ddl for sqlserver #8114 #8936

BookTraceless · 2025-03-08T02:19:57Z

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
If you are contributing the connector code, please check that the following files are updated:
1. Update plugin-mapping.properties and add new connector information in it
2. Update the pom file of seatunnel-dist
3. Add ci label in label-scope-conf
4. Add e2e testcase in seatunnel-e2e
5. Update connector plugin_config
Update the release-note.

# Conflicts: # seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-ddl/src/test/java/org/apache/seatunnel/connectors/jdbc/SqlServerSchemaChangeIT.java

davidzollo

+1
LGTM

hailin0

Please refer to the changes in this PR

#8380

hailin0 · 2025-03-08T14:53:28Z

cc @hawk9821

BookTraceless · 2025-03-08T15:21:51Z

Sir, I see that the reference modification is a public class. What specific changes should be made in the code I submitted?

hailin0 · 2025-03-08T15:33:10Z

Please update docs

BookTraceless · 2025-03-08T15:35:12Z

OK, thank you, I see.

…he#8114

BookTraceless · 2025-03-08T15:49:50Z

@hailin0
Sir, it's done

hailin0 · 2025-03-10T01:53:53Z

waiting for ci passed

Hisoka-X · 2025-03-10T02:21:52Z

Thanks @Aiden-Rose .

Please do not close/reopen to re-trigger ci. It will lost ci status.
Please fix failed ci in https://github.com/Aiden-Rose/seatunnel/actions/runs/13739107207/job/38426331775

...he/seatunnel/connectors/seatunnel/jdbc/catalog/sqlserver/SqlServerCreateTableSqlBuilder.java

.../apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/sqlserver/SqlServerDialect.java

zhilinli123 · 2025-03-10T03:52:23Z

.../apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/sqlserver/SqlServerDialect.java

+        StringBuilder sqlBuilder =
+                new StringBuilder("ALTER TABLE ")
+                        .append(tableIdentifier(tablePath))
+                        .append(" ALTER COLUMN ")


With StringBuilder repeated redundancy above, it is possible to encapsulate a common writing method

zhilinli123 · 2025-03-10T03:53:53Z

.../apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/sqlserver/SqlServerDialect.java

+                                + "AND TABLE_SCHEMA = '%s' AND TABLE_NAME = '%s' AND COLUMN_NAME = '%s';",
+                        tablePath.getDatabaseName(),
+                        tablePath.getSchemaName(),
+                        tablePath.getTableName(),


sql concatenation as above uses a common approach to reduce redundancy

zhilinli123 · 2025-03-10T03:54:44Z

.../apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/sqlserver/SqlServerDialect.java

+            if (rs.next()) {
+                return rs.getString("IS_NULLABLE").equals("YES");
+            } else {
+                throw new SQLException("Column not found: " + column);


Print detail log

BookTraceless · 2025-03-10T16:23:04Z

I don't know how to solve it.

hawk9821 · 2025-03-11T07:36:18Z

I don't know how to solve it.

change the sqlserver image , Refer to JdbcSqlServerIT

davidzollo

+1

shupan.yan added 3 commits March 8, 2025 10:04

[Feature][Jdbc] Support sink ddl for sqlserver apache#8114

46a3b8f

[Feature][Jdbc] Support sink ddl for sqlserver apache#8114

2dd846b

Merge remote-tracking branch 'origin/dev' into dev

189a5df

# Conflicts: # seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-ddl/src/test/java/org/apache/seatunnel/connectors/jdbc/SqlServerSchemaChangeIT.java

github-actions bot added connectors-v2 e2e jdbc labels Mar 8, 2025

davidzollo added the First-time contributor First-time contributor label Mar 8, 2025

This comment was marked as outdated.

Sign in to view

davidzollo previously approved these changes Mar 8, 2025

View reviewed changes

github-actions bot added approved reviewed labels Mar 8, 2025

hailin0 reviewed Mar 8, 2025

View reviewed changes

[Feature][Jdbc] Update docs for sqlserver in schema-evolution.md apac…

5638f1c

…he#8114

BookTraceless dismissed davidzollo’s stale review via 5638f1c March 8, 2025 15:45

github-actions bot added document and removed approved reviewed labels Mar 8, 2025

BookTraceless requested review from davidzollo and hailin0 March 8, 2025 16:21

davidzollo requested a review from hawk9821 March 9, 2025 03:00

BookTraceless closed this Mar 10, 2025

BookTraceless reopened this Mar 10, 2025

[Fix][Jdbc] Change domain name apache#8114

9b4bdf1

[Fix][Jdbc] Change port

b291ef9

zhilinli123 reviewed Mar 10, 2025

View reviewed changes

...he/seatunnel/connectors/seatunnel/jdbc/catalog/sqlserver/SqlServerCreateTableSqlBuilder.java Outdated Show resolved Hide resolved

zhilinli123 reviewed Mar 10, 2025

View reviewed changes

.../apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/sqlserver/SqlServerDialect.java Outdated Show resolved Hide resolved

zhilinli123 reviewed Mar 10, 2025

View reviewed changes

[Fix][Jdbc] 容器暴露端口出来

7ffd79f

github-actions bot added the CI&CD label Mar 10, 2025

[Fix][Jdbc] 容器暴露端口出来

29d313b

github-actions bot removed the CI&CD label Mar 10, 2025

[Fix][Jdbc] SqlServer服务报漏端口1433

ce6527e

github-actions bot added the CI&CD label Mar 10, 2025

[Fix][Jdbc] SqlServer服务报漏端口1433

8ea7ab1

github-actions bot removed the CI&CD label Mar 10, 2025

shupan.yan added 2 commits March 10, 2025 23:18

[Fix][Jdbc] SqlServer initSinkContainer 初始化方法更改

d198cc3

[Fix][Jdbc] SqlServer code style

12c08b7

shupan.yan added 5 commits March 14, 2025 14:46

[Fix][Jdbc] SqlServer update image server:2022-latest.

0f40bd8

[Fix][Jdbc] Code stale.

a50a751

[Fix][Jdbc] Increase the container startup timeout.

bb7f25d

[Fix][Jdbc] Change localhost.

335dbb4

[Fix][Jdbc] SqlServer schema change test support XA optimization.

a0a49e7

BookTraceless requested a review from zhilinli123 March 14, 2025 14:07

hailin0 approved these changes Mar 15, 2025

View reviewed changes

github-actions bot added approved reviewed labels Mar 15, 2025

davidzollo approved these changes Mar 15, 2025

View reviewed changes

davidzollo merged commit 30aa485 into apache:dev Mar 15, 2025
2 of 3 checks passed

[Feature][Jdbc] Support sink ddl for sqlserver #8114 #8936

[Feature][Jdbc] Support sink ddl for sqlserver #8114 #8936

Uh oh!

Conversation

BookTraceless commented Mar 8, 2025

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Uh oh!

This comment was marked as outdated.

davidzollo left a comment

Choose a reason for hiding this comment

Uh oh!

hailin0 left a comment

Choose a reason for hiding this comment

Uh oh!

hailin0 commented Mar 8, 2025

Uh oh!

BookTraceless commented Mar 8, 2025

Uh oh!

hailin0 commented Mar 8, 2025

Uh oh!

BookTraceless commented Mar 8, 2025

Uh oh!

BookTraceless commented Mar 8, 2025

Uh oh!

hailin0 commented Mar 10, 2025

Uh oh!

Hisoka-X commented Mar 10, 2025

Uh oh!

Uh oh!

Uh oh!

zhilinli123 Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

zhilinli123 Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

zhilinli123 Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

BookTraceless commented Mar 10, 2025

Uh oh!

hawk9821 commented Mar 11, 2025

Uh oh!

davidzollo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants