Skip to content

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Dec 5, 2024

Purpose of this pull request

Force set AsyncLogger.ThreadNameStrategy=UNCACHED to avoid thread name cache. Thread name cache will cause task log prefix thread name not match job id. Please refer https://issues.apache.org/jira/browse/LOG4J2-2052.

Does this PR introduce any user-facing change?

no

How was this patch tested?

tested in local

Check list

@Hisoka-X Hisoka-X marked this pull request as draft December 5, 2024 02:38
@github-actions github-actions bot added the core SeaTunnel core module label Dec 5, 2024
@Hisoka-X Hisoka-X marked this pull request as ready for review December 5, 2024 04:01
@Hisoka-X
Copy link
Member Author

Hisoka-X commented Dec 5, 2024

cc @hailin0

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

waiting for ci passed

<elasticsearch7.client.version>7.5.1</elasticsearch7.client.version>
<flink-shaded-hadoop-2.version>2.7.5-7.0</flink-shaded-hadoop-2.version>
<commons-lang3.version>3.5</commons-lang3.version>
<commons-lang3.version>3.8</commons-lang3.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 5, 2024
@hailin0 hailin0 merged commit 150d30d into apache:dev Dec 6, 2024
5 checks passed
@Hisoka-X Hisoka-X deleted the fix-log4j-bug branch December 9, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved core SeaTunnel core module dependencies Pull requests that update a dependency file reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants