[hotfix] fix exceptions caused by operator priority in connector-clickhouse when using sharding_key #8162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
&Operator priority is lower than%, resulting in the program not executing as expected
Contributor
|
Run |
Contributor
@supernovaYe please fix ci |
Member
|
Could you mind add an unit test for this method? https://github.com/apache/seatunnel/pull/8162/files#diff-f4bb0831ff0d565061930b5e556ec8836783b1ba1420515d29d4a216aa37ba96R106 Thanks. |
Contributor
Author
|
Sure, I will fix ci and complete an unit tests after I finish my work |
Hisoka-X
reviewed
Jan 7, 2025
Comment on lines
47
to
48
| @Test | ||
| public void test() { |
Member
There was a problem hiding this comment.
This test case useless. Please remove it.
| } | ||
|
|
||
| @Test | ||
| public void test2() { |
Member
There was a problem hiding this comment.
Suggested change
| public void test2() { | |
| public void testWithShardRouterGetShardRight() { |
Hisoka-X
approved these changes
Jan 7, 2025
hailin0
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
fix of #8161
Does this PR introduce any user-facing change?
no
How was this patch tested?
tested locally using over 10000 data points and obtained the maximum and minimum values of the modulus after hashing
Check list
New License Guide
release-note.