Skip to content

Conversation

@XenosK
Copy link
Contributor

@XenosK XenosK commented Oct 15, 2024

Purpose of this pull request

fix: #7794

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case.

@github-actions github-actions bot added the e2e label Oct 15, 2024
@XenosK
Copy link
Contributor Author

XenosK commented Oct 15, 2024

Please add test case.

Test case have been added, take a look.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XenosK and others added 7 commits October 16, 2024 11:01
…ain/java/org/apache/seatunnel/connectors/cdc/base/source/enumerator/splitter/AbstractJdbcSourceChunkSplitter.java

Co-authored-by: Jia Fan <[email protected]>
…ain/java/org/apache/seatunnel/connectors/cdc/base/dialect/JdbcDataSourceDialect.java

Co-authored-by: Jia Fan <[email protected]>
…ain/java/org/apache/seatunnel/connectors/cdc/base/dialect/JdbcDataSourceDialect.java

Co-authored-by: Jia Fan <[email protected]>
@XenosK XenosK changed the title [Feature][Connector-V2]Jdbc chunk split add “snapshot.split.column” params #7794 [Feature][Connector-V2]Jdbc chunk split add snapshotSplitColumn config #7794 Nov 11, 2024
hailin0
hailin0 previously approved these changes Nov 12, 2024
Hisoka-X
Hisoka-X previously approved these changes Nov 13, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XenosK !

@Hisoka-X Hisoka-X merged commit b6c6dc0 into apache:dev Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants