Skip to content

Conversation

@liugddx
Copy link
Member

@liugddx liugddx commented Sep 17, 2023

Purpose of this pull request

Check list

@liugddx liugddx linked an issue Sep 17, 2023 that may be closed by this pull request
3 tasks
@liugddx liugddx requested review from EricJoy2048 and TyrantLucifer and removed request for TyrantLucifer September 17, 2023 09:03
@liugddx
Copy link
Member Author

liugddx commented Sep 19, 2023

@EricJoy2048 PTAL

@Hisoka-X
Copy link
Member

After this PR merged, would CI not run any test case of jindo?

@liugddx
Copy link
Member Author

liugddx commented Sep 19, 2023

After this PR merged, would CI not run any test case of jindo?

Since Jindo's driver occasionally cannot be downloaded, this will cause an error to be reported during the compilation phase, this pr is to solve this problem. Jindo has no test case coverage.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit a14d9c0 into apache:dev Sep 19, 2023
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UT failed due to download jindo-core dependency

3 participants