-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Bugfix][Connector-v2] fix file sink isPartitionFieldWriteInFile occurred exception when no columns are given
#5508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…curred exception when no columns are give for the sink
Hisoka-X
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM expect one minor comment. cc @TyrantLucifer
| if (CollectionUtils.isEmpty(this.sinkColumnList)) { | ||
| this.sinkColumnList = Arrays.asList(seaTunnelRowTypeInfo.getFieldNames()); | ||
| this.sinkColumnList = | ||
| new ArrayList<>(Arrays.asList(seaTunnelRowTypeInfo.getFieldNames())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some comment in here. Only read the code will confused developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comment in bug fix code
|
@chovy-3012 Could you retry the failed CI? https://github.com/chovy-3012/seatunnel/actions/runs/6492030625/job/17630262359 |
Retried more than 10 times , still failed. error message as below: [INFO] Running org.apache.seatunnel.connectors.seatunnel.jdbc.JdbcAutoGenerateSQLIT
Error: Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 8.34 s <<< FAILURE! - in org.apache.seatunnel.connectors.seatunnel.jdbc.JdbcAutoGenerateSQLIT
Error: org.apache.seatunnel.connectors.seatunnel.jdbc.JdbcAutoGenerateSQLIT Time elapsed: 8.34 s <<< ERROR!
java.util.concurrent.CompletionException: org.testcontainers.containers.ContainerLaunchException: Container startup failed
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed
Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=postgres:14-alpine, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@489496a9)
Caused by: org.testcontainers.containers.ContainerFetchException: Failed to get Docker client for postgres:14-alpine
Caused by: com.github.dockerjava.api.exception.DockerClientException: Could not pull image: failed to register layer: write /usr/lib/libLLVM-15.so: no space left on device |
Purpose of this pull request
Check list
New License Guide
release-note.bug as below:
I want to sink data from Kafka in text format, partitioned by date, into different HDFS directories, and the data does not contain timestamps.
test.conf :
cmd:
exception:
bux fix:
fix file sink
isPartitionFieldWriteInFileoccurred exception when no columns are given for the sink