Skip to content

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Sep 4, 2023

Purpose of this pull request

At now, if seatunnel task executed success, return normally, the close method of SeaTunnelTask will be invoke twice, once in SeaTunnelTask, another in TaskExecutionService finally block. This PR change the behavior in TaskExecutionService, only invoke close when task return not normally.

Check list

@Hisoka-X
Copy link
Member Author

Hisoka-X commented Sep 4, 2023

@ic4y @hailin0 I think you should take a look.

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Sep 4, 2023
@EricJoy2048 EricJoy2048 merged commit d1e9673 into apache:dev Sep 6, 2023
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
@Hisoka-X Hisoka-X deleted the engine_close_twice branch September 15, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants