-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: support devcontainer #11765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support devcontainer #11765
Conversation
|
I have tested this on However, I don't have a desktop system running Linux, which would require someone else to help test, but that should not be a problem. |
|
The error in the CI is not related to this PR, it also fails on other PRs, will investigate it later. UPDATEI have fixed the issue in #11769. |
5533908 to
44bc599
Compare
|
🆒 I will help with testing using Manjaro KDE Plasma(amd64) + Docker Engine. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
|
This PR has been renovated, where the tests can run correctly, except for a problem that needs to be solved by #12070. |
|
Merging the master branch to fix #12070 doesn't seem to be successful, I'll rebase and force push. |
cf3b2f4 to
183ad13
Compare
Baoyuantop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on my arm macOS.
|
|
||
| :::note | ||
|
|
||
| The following uses Visual Studio Code, which has built-in integration with Dev Containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to install the Dev Containers extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Baoyuantop Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, it is pre-included. I mentioned that "which has built-in integration"
|
I confirmed that the test failure is not related to this PR, so maybe we can merge this PR first and continue to improve usability in subsequent PRs. This PR has been open for too long. |
Co-authored-by: YYYoung <[email protected]>
Co-authored-by: YYYoung <[email protected]>
juzhiyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried locally and works well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
These warnings will be fixed in a later PR. I will merge this PR first. |
Co-authored-by: SkyeYoung <[email protected]>








Description
Add devcontainer support to the project, which is expected to cover
Linux, Windows (WSL2), macOSOSs, and theamd64, arm64CPU ISAs, i.e. the environments used by most developers.Basically, the container provides an isolated environment from the host, the runtime and toolset required for APISIX development are built in the container build, they will be available out of the box and developers no longer need to build and install them on the host. Just start dev container, wait a few moments, and it's ready to go.
Significantly simplify the parts that may be unfamiliar to developers and just focus on writing Lua code and test cases.
In addition to this, etcd is ready, maintained by docker-compose, and accessible on the local loopback.
Checklist