Skip to content

Conversation

@reneleonhardt
Copy link

Chores

  • Update github-actions
  • Let dependabot update github-actions and pip

@reneleonhardt
Copy link
Author

Notes

  • It would be great if unnecessary CI jobs would be skipped in forks (i.e. safety requiring license keys)
  • It would be nice if main.py wouldn't fail if running in forks (akaihola/darker is hardcoded there, GITHUB_REPOSITORY contains the actual repo)

@akaihola
Copy link
Owner

  • Update github-actions

@reneleonhardt, do you mean to update all 3rd party GitHub actions used in workflows to most current versions?

  • Let dependabot update github-actions and pip

I assume this would be done by following the Enabling dependabot for your repository instructions?

  • It would be great if unnecessary CI jobs would be skipped in forks (i.e. safety requiring license keys)

Do you have a recipe for how to make this happen?

  • It would be nice if main.py wouldn't fail if running in forks (akaihola/darker is hardcoded there, GITHUB_REPOSITORY contains the actual repo)

Cool, that makes sense. So essentially just replace akaihola/darker by GITHUB_REPOSITORY everywhere in workflows?

@akaihola
Copy link
Owner

@reneleonhardt ah, oops, it's late and I thought I was reading an issue and not a PR – so you did most of this already in your changes. Thanks!

- uses: actions/checkout@v5
- name: Install uv
uses: astral-sh/setup-uv@v4
uses: astral-sh/setup-uv@v6
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there's a

Suggested change
uses: astral-sh/setup-uv@v6
uses: astral-sh/setup-uv@v7

already. Same in a few other workflow files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants