Skip to content

feat: add hidden accessor for tag #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackgerrits merged 3 commits into from
Feb 22, 2023
Merged

feat: add hidden accessor for tag #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8cfd18
feat: add hidden accessor for tag
jackgerrits Feb 22, 2023
22a658c
Update _core.pyi
jackgerrits Feb 22, 2023
123f331
Merge branch 'main' into tag_func
jackgerrits Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,8 @@ PYBIND11_MODULE(_core, m)
[&](VW::cs_label* cs_label) { ex.l.cs = *cs_label; },
},
label);
});
})
.def("_get_tag", [](VW::example& ex) -> std::string { return std::string(ex.tag.data(), ex.tag.size()); });

py::class_<workspace_with_logger_contexts>(m, "Workspace")
.def(py::init(
Expand Down
1 change: 1 addition & 0 deletions src/vowpal_wabbit_next/_core.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ class DenseParameters():
class Example():
def __init__(self) -> None: ...
def _get_label(self, arg0: LabelType) -> typing.Union[SimpleLabel, MulticlassLabel, CBLabel, CSLabel, None]: ...
def _get_tag(self) -> str: ...
def _is_newline(self) -> bool: ...
def _set_label(self, arg0: typing.Union[SimpleLabel, MulticlassLabel, CBLabel, CSLabel, None]) -> None: ...
pass
Expand Down