Skip to content

Conversation

@sharadregoti
Copy link
Contributor

@sharadregoti sharadregoti commented Dec 6, 2025

PR Type

Documentation


Description

  • Update FIPS packaging details

  • Remove Docker image reference

  • Clarify RPM and DEB availability

  • Retain BoringCrypto and suffix notes


Diagram Walkthrough

flowchart LR
  doc["FIPS release docs"] -- "replace packaging info" --> pkg["RPM/DEB packages"]
  doc -- "remove reference" --> docker["Docker images"]
  pkg -- "clarify availability" --> access["Not publicly accessible"]
Loading

File Walkthrough

Relevant files
Documentation
fips-release.mdx
Update FIPS packaging from Docker to RPM/DEB                         

developer-support/release-types/fips-release.mdx

  • Replace Docker images mention with RPM/DEB packages.
  • Clarify availability scope of FIPS packages.
  • Preserve notes on BoringCrypto and -fips suffix.
+1/-1     

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Clarity

The new sentence about availability is slightly awkward and possibly redundant. Consider rephrasing to clearly state that only RPM and DEB packages are available (no Docker images) and that they are not publicly accessible.

**FIPS-compliant** means that the FIPS Tyk Product only uses FIPS 140-2 approved cryptographic algorithms (see below) when running in FIPS mode. This is only available to specific Tyk-built RPM and DEB packages FIPS Tyk Product. These packages and images are not publicly accessible.
Grammar

There is a double period after "certified" in the preceding unchanged sentence; consider fixing punctuation for professionalism.

Tyk provides a **FIPS-compliant package** of the Tyk Gateway (Enterprise Edition) and Tyk Pump (together, the *FIPS Tyk Product*). Please note that the FIPS Tyk Product has not been submitted to a [NIST](https://www.nist.gov/federal-information-processing-standards-fips) testing lab for validation and Tyk is not FIPS certified.. 

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Fix grammar and remove image mention

The sentence has grammatical issues and still references "images" after removing
Docker. Clarify package types and remove mention of images to avoid contradicting
the stated removal. Also add a missing preposition for readability.

developer-support/release-types/fips-release.mdx [33]

-**FIPS-compliant** means that the FIPS Tyk Product only uses FIPS 140-2 approved cryptographic algorithms (see below) when running in FIPS mode. This is only available to specific Tyk-built RPM and DEB packages FIPS Tyk Product. These packages and images are not publicly accessible.
+**FIPS-compliant** means that the FIPS Tyk Product only uses FIPS 140-2 approved cryptographic algorithms (see below) when running in FIPS mode. This is only available for specific Tyk-built RPM and DEB packages of the FIPS Tyk Product. These packages are not publicly accessible.
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies and fixes grammatical issues and the incorrect mention of "images" in line 33 of the new hunk. It improves clarity and consistency with the PR's intent but is a minor content correction, not a critical issue.

Medium

@sharadregoti sharadregoti merged commit 0988922 into main Dec 6, 2025
7 checks passed
@buger
Copy link
Member

buger commented Dec 6, 2025

/release to release-5.8

@buger
Copy link
Member

buger commented Dec 6, 2025

/release to release-5.10

buger pushed a commit that referenced this pull request Dec 6, 2025
(cherry picked from commit 0988922)
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

✅ Cherry-pick successful. A PR was created and auto-merged (if allowed): #1149

buger pushed a commit that referenced this pull request Dec 6, 2025
(cherry picked from commit 0988922)
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

✅ Cherry-pick successful. A PR was created and auto-merged (if allowed): #1150

buger added a commit that referenced this pull request Dec 6, 2025
buger added a commit that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants