-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix enex import stores wrong format in database for dateCreated, dateModified #7718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enex import stores wrong format in database for dateCreated, dateModified #7718
Conversation
…ields) the proper format for dateCreated, dateModified is: +0000
to protect from future potential refactoring
Summary of ChangesHello @contributor, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the Enex import functionality that caused Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses a bug where dateCreated and dateModified were stored in an incorrect format during ENEX file imports. The introduction of the formatDateTimeToLocalDbFormat function and its use of dayjs to format dates into the expected local time format with a timezone offset is a solid fix. The changes are logical and well-contained. I've added one suggestion to refactor the new helper function for improved readability and to align with modern TypeScript best practices.
This PR fixes bug in enex import.
The problem is that dateCreated, dateModified field values get wrong format during import (Z, without hours offset), while trilium app expects the fields to be in format
2025-11-12 21:38:51.110+0100(or in2025-11-12 21:38:51.110+0000if your timezone is UTC).Data from DB to illustrate the problem:

Data from enex file:
Original data in evernote:

With this PR, data in DB is:

dateCreatedanddateModifiedare converted to electron/server local time zone from enex's UTC value. This is what most users would expect.